Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assorted fixes in the "multiregion dns" command #13

Merged
merged 6 commits into from
Aug 7, 2023
Merged

assorted fixes in the "multiregion dns" command #13

merged 6 commits into from
Aug 7, 2023

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Aug 5, 2023

Added

  • Print a message when running in read-only mode.

Fixed

  • Don't try to set the DNS record for the internal ECS services. We now use direct routing within each zone.
  • Don't fail the entire command if one DNS update fails.
  • Use the FQDN for the CNAME value.
  • Retain the Cloudflare DNS record comment when updating a record.

@briskt briskt requested a review from a team August 5, 2023 02:52
@briskt briskt merged commit d8e3fa3 into develop Aug 7, 2023
@briskt briskt deleted the feature/dns-cleanup branch August 7, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-jackson jason-jackson jason-jackson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @jason-jackson